Feature/INT-1638 - General SDK update (Issuing cards/disputes, Payment Setups, Klarna, and Platforms instrument details)#614
Merged
Conversation
…nd Platforms instrument details)
|
armando-rodriguez-cko
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request primarily introduces new classes to support ACH instrument details and bank account types. These changes help streamline model definitions and prepare the codebase for alternative serialization strategies or libraries.
Additionally, it removes the use of the
@SerializedNameannotation from most domain model classes in thecom.checkout.accountspackage, simplifying the codebase and decoupling it from Gson-specific serialization.The most important changes are:
New Payment Methods Support:
PaymentMethodsmodel. This allows handling these payment types in payment setups.Order Amount Allocation and Commission:
PaymentSetupAmountAllocation,AmountAllocationCommission, and related models to support order splitting among sub-entities and specifying commissions per split. TheOrderclass now includes anAmountAllocationsproperty for this purpose.Payment Setup Enhancements:
PaymentSetupBillingDescriptor,PaymentSetupPresentmentDetails, andPaymentSetupTerminalclasses to enrich payment setup configuration and response, allowing for more detailed billing, presentment, and terminal information. These are now included in thePaymentSetupsResponse.Bank Account and Instrument Details:
InstrumentAccountTypeenum andInstrumentDetailsAchclass to support specifying bank account types (savings/checking) and ACH instrument details.Other Payment Method Updates:
KlarnaAccountHolderto reflect the account holder's name as returned by Klarna after verification.Removal of Gson
@SerializedNameannotations:@SerializedNameannotations have been removed from model classes such asRequestMetrics,AccountPhone,AccountsAccountHolder,AccountsCorporateAccountHolder,AccountsIndividualAccountHolder,AccountsPaymentInstrument,Company,ContactDetails,EntityDocument,EntityFinancialDetails,EntityFinancialDocuments,EntityRequirementListItem,EntityRequirementUpdateResponse,Identification,Individual,InstrumentDetailsFasterPayments,InstrumentDetailsSepa, andInstrumentDocument. This reduces dependency on Gson and cleans up the code. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28] [29] [30] [31] [32] [33] [34]These changes modernize the codebase, reduce serialization coupling, and add support for new instrument types.